Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change format of hours_to_expiration for materialized view #1174

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

karlohrn
Copy link

@karlohrn karlohrn commented Apr 9, 2024

to instead of using timestamp use a sql string.

Resolve #1173

Problem

Incorrect format of string missing "" around timestamp

Solution

change format to similare format solution used in impl.py
expiration = f'TIMESTAMP_ADD(CURRENT_TIMESTAMP(), INTERVAL {config.get("hours_to_expiration")} hour)'

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

…l string.

And fix problem where materialized views can't use expiration
Copy link

cla-bot bot commented Apr 9, 2024

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @karlohrn

@cla-bot cla-bot bot added the cla:yes label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] hours to expiration timeformat is incorrect for materialized view
1 participant