Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3.12 in workflow files and configs #1320

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

VersusFacit
Copy link
Contributor

@VersusFacit VersusFacit commented Aug 10, 2024

resolves #1104

Problem

Adding Python 3.12 should pass a series of tests

pytest tests/unit local
pytest tests/functional local
dbt seed && dbt run in a local jaffle shop using plain pip install dbt-redshift with 3.12 active
✅ smoke testing run using test-bundle on snowflake against the jaffle-shop-base scenario with 3.12.X active
✅ GHA workflow involving integration tests
✅ release workflow still works

Solution

No code changes required per my testing above.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@VersusFacit VersusFacit requested a review from a team as a code owner August 10, 2024 02:14
@cla-bot cla-bot bot added the cla:yes label Aug 10, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@VersusFacit VersusFacit added the Skip Changelog Skips GHA to check for changelog file label Aug 10, 2024
@VersusFacit
Copy link
Contributor Author

VersusFacit commented Aug 10, 2024

@VersusFacit VersusFacit changed the title Update workflows and integration test matricies Add support for 3.12 in workflow files and configs Aug 10, 2024
@colin-rogers-dbt colin-rogers-dbt merged commit 21aeca3 into main Aug 16, 2024
83 of 87 checks passed
@colin-rogers-dbt colin-rogers-dbt deleted the ADAP-1104/add_python_312_support branch August 16, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Spike on supporting Py3.12
3 participants