Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dev-requirements.txt look like other repos and work with update_dev_dependency_branches.sh #1324

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Aug 26, 2024

Problem

When updating the integration.yml workflow, updating dbt-core branch didn't work because the format in dev-requirements.txt didn't match what was expected in update_dev_dependency_branches.sh

Solution

Add the "#egg" snippet that the other repos have and that update_dev_dependency_branches.sh expects.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@gshank gshank added the Skip Changelog Skips GHA to check for changelog file label Aug 26, 2024
@gshank gshank requested a review from a team as a code owner August 26, 2024 18:44
@cla-bot cla-bot bot added the cla:yes label Aug 26, 2024
@gshank gshank merged commit 62d597a into main Aug 26, 2024
30 checks passed
@gshank gshank deleted the tweak_dev_requirements branch August 26, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants