Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the logs upload step for integration tests #1325

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

mikealfare
Copy link
Contributor

Problem

The new version of upload-artifacts requires a unique artifact name for upload whereas the old one allowed for overwriting the existing artifact. This was addressed for the test results, but not the logs resulting from running the tests.

Solution

Add the same uniqueness namespace to the logs artifact that is used for the test results artifact.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@mikealfare mikealfare self-assigned this Aug 27, 2024
@mikealfare mikealfare requested a review from a team as a code owner August 27, 2024 22:26
@cla-bot cla-bot bot added the cla:yes label Aug 27, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

1 similar comment
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Aug 27, 2024
@mikealfare mikealfare enabled auto-merge (squash) August 27, 2024 23:11
@mikealfare mikealfare merged commit de2bca1 into main Aug 27, 2024
28 of 30 checks passed
@mikealfare mikealfare deleted the fix-integration-test-logs-upload branch August 27, 2024 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants