add merge exclude tests -- use adapter zone test #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
jtcohen6
added
the
ready_for_review
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide. |
…bt-bigquery into feature/merge-exclude-columns
|
I assume this will be unpinned and sent back to main before merge? |
|
@VersusFacit that's the idea! once dbt-core is rocking and rolling, we can unpin and re-test |
colin-rogers-dbt
approved these changes
Jan 30, 2023
VersusFacit
reviewed
Feb 7, 2023
| @@ -93,5 +93,4 @@ def test__bigquery__incremental_merge_columns(self): | |||
| "seed-paths": ["seeds-merge-cols-update"] | |||
| }) | |||
| self.seed_and_run() | |||
| self.assertTablesEqual("incremental_update_cols", "expected_result") | |||
|
|
|||
| self.assertTablesEqual("incremental_update_cols", "expected_result") | |||
There was a problem hiding this comment.
good auto formatting lol
VersusFacit
approved these changes
Feb 7, 2023
VersusFacit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #5260 (dbt-core issue)
Description
This PR adds integration tests for the associated logic change in dbt-core PR #5457
Related PRs:
Checklist
CHANGELOG.mdand added information about my change to the "dbt-bigquery next" section.