Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate changing_relation_type test #351

Merged
merged 4 commits into from
Oct 13, 2022
Merged

migrate changing_relation_type test #351

merged 4 commits into from
Oct 13, 2022

Conversation

colin-rogers-dbt
Copy link
Contributor

Adapter PR for Core PR: dbt-labs/dbt-core#6054

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Oct 12, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@colin-rogers-dbt colin-rogers-dbt added the Skip Changelog Skips GHA to check for changelog file label Oct 12, 2022
McKnight-42
McKnight-42 reviewed Oct 12, 2022
View reviewed changes
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need to have a standalone bigquery test I think you have to do a full refresh run to go from a table to a view if i'm not mistaken

@colin-rogers-dbt
Copy link
Contributor Author

might need to have a standalone bigquery test I think you have to do a full refresh run to go from a table to a view if i'm not mistaken

Added extra args option in dbt-core to support doing a full-refresh

McKnight-42
McKnight-42 approved these changes Oct 13, 2022
View reviewed changes
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colin-rogers-dbt colin-rogers-dbt merged commit 1762ee0 into main Oct 13, 2022
@colin-rogers-dbt colin-rogers-dbt deleted the 034_test_migration branch October 13, 2022 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@McKnight-42 McKnight-42 McKnight-42 approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@colin-rogers-dbt @McKnight-42