Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BACKPORT] #411 #413

Merged
merged 5 commits into from
Dec 8, 2022
Merged

[BACKPORT] #411 #413

merged 5 commits into from
Dec 8, 2022

Conversation

McKnight-42
Copy link
Contributor

@McKnight-42 McKnight-42 commented Dec 7, 2022 •
edited
Loading

resolves #

Description

In tox 4, space-separated variables specified for passenv are not passed into the container.

[testenv:inline]
passenv = FOO BAR
☝️ doesn't work on tox 4

[testenv:separate-lines]
passenv =
    FOO
    BAR

Checklist

@cla-bot cla-bot bot added the cla:yes label Dec 7, 2022
@McKnight-42 McKnight-42 requested review from jtcohen6, mikealfare and nathaniel-may and removed request for mikealfare December 7, 2022 21:54
@VersusFacit VersusFacit self-requested a review December 8, 2022 09:21
VersusFacit
VersusFacit reviewed Dec 8, 2022
View reviewed changes
tox.ini Outdated
passenv =
DBT_*
BIGQUERY_TEST_*
PYTEST_ADDOPTS DATAPROC_*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should these actually be on separate lines or are they fine

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VersusFacit Good catch!!

@McKnight-42 Let's get that fixed for the original PR + other backports

VersusFacit
VersusFacit approved these changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@VersusFacit VersusFacit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending my one concern above

@McKnight-42 McKnight-42 merged commit 02ebf7f into 1.2.latest Dec 8, 2022
@McKnight-42 McKnight-42 deleted the backport-411-1.2.latest branch December 8, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VersusFacit VersusFacit VersusFacit approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

@nathaniel-may nathaniel-may Awaiting requested review from nathaniel-may

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@McKnight-42 @jtcohen6 @VersusFacit