add test for enforcing contracts on incremental materializations #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
force-pushed
the
er/ct-2293-incremental-mat
branch
2 times, most recently
from
cb93842 to
4821db5
Compare
emmyoop
requested review from
McKnight-42 and
mikealfare
and removed request for
McKnight-42
MichelleArk
approved these changes
Mar 23, 2023
mikealfare
reviewed
Mar 27, 2023
|
|
||
| @pytest.fixture(scope="class") | ||
| def expected_error_messages(self): | ||
| return ["Required field id cannot be null"] |
There was a problem hiding this comment.
Add a newline at the end here so that the linters don't freak out. I'm actually surprised it passed the code checks. Perhaps we didn't turn it on for tests/functional yet in dbt-spark.
emmyoop
force-pushed
the
er/ct-2293-incremental-mat
branch
from
4821db5 to
58466db
Compare
mikealfare
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves dbt-labs/dbt-core#7154
Description
Adds (and reorganizes) tests.
Checklist
changie newto create a changelog entry