-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batch_id
param to profile to pass along with dataproc_v1.CreateBatchRequest
#727
Add batch_id
param to profile to pass along with dataproc_v1.CreateBatchRequest
#727
Conversation
…aproc.v1.CreateBatchRequest
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR. CLA has not been signed by users: @nickozilla |
batch_id
param to profile to pass along with google.cloud.dataproc.v1.CreateBatchRequestbatch_id
param to profile to pass along with google.cloud.dataproc.v1.CreateBatchRequest
batch_id
param to profile to pass along with google.cloud.dataproc.v1.CreateBatchRequest
batch_id
param to profile to pass along with dataproc_v1.CreateBatchRequest
Can you update the credentials fixtures we use to test to include this new parameter? https://github.com/dbt-labs/dbt-bigquery/blob/main/tests/conftest.py#L35 |
Sure thing, added in latest commit @colin-rogers-dbt |
Please update the test environment template as well: https://github.com/dbt-labs/dbt-bigquery/blob/main/test.env.example. Otherwise it looks good. |
Thanks for the suggestion, added in latest commit @mikealfare |
resolves #671
Description
This PR enables an optional profile parameter
batch_id
which gets passed into thedataproc_v1.CreateBatchRequest
, so users can give their batch jobs a name.Checklist
changie new
to create a changelog entry