Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add batch_id param to profile to pass along with dataproc_v1.CreateBatchRequest #727

Merged

Conversation

nickozilla
Copy link
Contributor

@nickozilla nickozilla commented May 16, 2023

resolves #671

Description

This PR enables an optional profile parameter batch_id which gets passed into the dataproc_v1.CreateBatchRequest, so users can give their batch jobs a name.

Checklist

@cla-bot
Copy link

cla-bot bot commented May 16, 2023

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @nickozilla

@nickozilla nickozilla changed the title Add batch_id param to profile to pass along with google.cloud.dataproc.v1.CreateBatchRequest Add batch_id param to profile to pass along with google.cloud.dataproc.v1.CreateBatchRequest May 16, 2023
@nickozilla nickozilla changed the title Add batch_id param to profile to pass along with google.cloud.dataproc.v1.CreateBatchRequest Add batch_id param to profile to pass along with dataproc_v1.CreateBatchRequest May 17, 2023
@cla-bot cla-bot bot added the cla:yes label May 17, 2023
@nickozilla nickozilla marked this pull request as ready for review May 17, 2023 12:11
@nickozilla nickozilla requested a review from a team as a code owner May 17, 2023 12:11
@dbeatty10 dbeatty10 added the triage:ready-for-review Externally contributed PR has functional approval, ready for code review from Core engineering label May 17, 2023
@nickozilla
Copy link
Contributor Author

nickozilla commented May 17, 2023

Tested locally:

Screenshot 2023-05-17 at 13 09 09

Screenshot 2023-05-17 at 13 10 12

@colin-rogers-dbt
Copy link
Contributor

Can you update the credentials fixtures we use to test to include this new parameter? https://github.com/dbt-labs/dbt-bigquery/blob/main/tests/conftest.py#L35

@nickozilla
Copy link
Contributor Author

Sure thing, added in latest commit @colin-rogers-dbt

@mikealfare
Copy link
Contributor

Please update the test environment template as well: https://github.com/dbt-labs/dbt-bigquery/blob/main/test.env.example. Otherwise it looks good.

@nickozilla
Copy link
Contributor Author

Thanks for the suggestion, added in latest commit @mikealfare

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes triage:ready-for-review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ADAP-462] [Feature] Allow override of CreateBatchRequest for batch_id
5 participants