Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sql_header tests for constraints #750

Merged
merged 5 commits into from
Jun 22, 2023

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented May 31, 2023

resolves dbt-labs/dbt-core#7714

associated core PR: dbt-labs/dbt-core#7734

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label May 31, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide.

@MichelleArk MichelleArk marked this pull request as ready for review June 1, 2023 17:28
@MichelleArk MichelleArk requested a review from a team as a code owner June 1, 2023 17:28
@MichelleArk MichelleArk requested review from Fleid and McKnight-42 June 1, 2023 17:28
Copy link
Contributor

@github-christophe-oudar github-christophe-oudar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the revert on dev-requirements.txt

dev-requirements.txt Outdated Show resolved Hide resolved
@colin-rogers-dbt colin-rogers-dbt merged commit 9b3243b into main Jun 22, 2023
@colin-rogers-dbt colin-rogers-dbt deleted the 7714/model-contracts-sql-header branch June 22, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2606] [Bug] Contract enforcement checks do not sent SQL header
3 participants