Standardize the adapter for core debug changes. #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the dbt-bigquery contributing guide. |
VersusFacit
commented
Jun 4, 2023
| "keyfile", | ||
| "keyfile_json", | ||
| "timeout_seconds", | ||
| "token", |
There was a problem hiding this comment.
Do we want to hide these tokens? If so, what other ones?
|
fixed with some key tweaks |
VersusFacit
force-pushed
the
ADAP-496/add_test_connection_mode_to_debug
branch
from
df97653 to
500c26a
Compare
9 tasks
McKnight-42
approved these changes
Jun 7, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to bring adapter in parity with this core PR.
Now will use the bigquery adapter query and will show all credential lines in
_connection_keys.Feedback Requested
In the connection keys, flag any that are sensitive and should not be shown to users in plaintext
Checklist
changie newto create a changelog entry