Use tmp table in static insert overwrite #821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbeatty10
commented
Jul 12, 2023
Comment on lines
87
to
90
| {%- if tmp_relation_exists -%} | ||
| -- 2. clean up the temp table | ||
| drop table if exists {{ tmp_relation }} | ||
| {%- endif -%} |
There was a problem hiding this comment.
Everything else above resolves #427
dbeatty10
commented
Jul 12, 2023
dbeatty10
commented
Jul 12, 2023
dbt/include/bigquery/macros/materializations/incremental_strategy/insert_overwrite.sql
Outdated
Show resolved
Hide resolved
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
|
Closing since #630 was the original with priority anyways. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #630 in order to align with the base branch and test. Content below copy-pasted from #630.
Resolves #427
Resolves #556
Description
As described in #427, static insert overwrite, when involving
on_schema_change != 'ignore'would create a temp table to check for a schema change anyway.It fixes as well:
on_schema_change = 'ignore'with dynamic insert overwrite where the SQL header would not be addedon_schema_change != 'ignore'where the temp table would not be deletedChecklist
changie newto create a changelog entry