Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add batch_id param to profile to pass along with dataproc_v1.CreateBatchRequest (#727)" #826

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Revert "Add batch_id param to profile to pass along with dataproc_v1.CreateBatchRequest (#727)" #826

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions .changes/unreleased/Features-20230517-092205.yaml
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion dbt/adapters/bigquery/connections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ class BigQueryCredentials(Credentials):
dataproc_region: Optional[str] = None
dataproc_cluster_name: Optional[str] = None
gcs_bucket: Optional[str] = None
batch_id: Optional[str] = None

dataproc_batch: Optional[DataprocBatchConfig] = field(
metadata={
Expand Down
1 change: 0 additions & 1 deletion dbt/adapters/bigquery/python_submissions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ def _submit_dataproc_job(self) -> dataproc_v1.types.jobs.Job:
request = dataproc_v1.CreateBatchRequest(
parent=parent,
batch=batch,
batch_id=self.credential.batch_id,
)
# make the request
operation = self.job_client.create_batch(request=request) # type: ignore
Expand Down
1 change: 0 additions & 1 deletion test.env.example
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,3 @@ DBT_TEST_USER_3="serviceAccount:dbt-integration-test-user@dbt-test-env.iam.gserv
DATAPROC_REGION=us-
DATAPROC_CLUSTER_NAME=
GCS_BUCKET=
BATCH_ID=
2 changes: 0 additions & 2 deletions tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ def oauth_target():
"dataproc_region": os.getenv("DATAPROC_REGION"),
"dataproc_cluster_name": os.getenv("DATAPROC_CLUSTER_NAME"),
"gcs_bucket": os.getenv("GCS_BUCKET"),
"batch_id": os.getenv("BATCH_ID"),
}


Expand All @@ -54,5 +53,4 @@ def service_account_target():
"DATAPROC_CLUSTER_NAME"
), # only needed for cluster submission method
"gcs_bucket": os.getenv("GCS_BUCKET"),
"batch_id": os.getenv("BATCH_ID"),
}