Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add datadog env vars #829

Merged
merged 1 commit into from
Jul 17, 2023
Merged

add datadog env vars #829

merged 1 commit into from
Jul 17, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jul 14, 2023

resolves #8081
docs dbt-labs/docs.getdbt.com/# n/a

Problem

Datadog not ingesting test data for flaky test visibility

Solution

Adds env vars to turn on test visibility in datadog. Datadog docs

Updates the tox command to include the --ddtrace flag only when running in CI.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jul 14, 2023
@cla-bot cla-bot bot added the cla:yes label Jul 14, 2023
@emmyoop emmyoop mentioned this pull request Jul 17, 2023
Closed
10 tasks
@emmyoop emmyoop marked this pull request as ready for review July 17, 2023 14:19
@emmyoop emmyoop requested a review from a team as a code owner July 17, 2023 14:19
@emmyoop emmyoop requested a review from mikealfare July 17, 2023 14:19
@emmyoop emmyoop merged commit ea258bb into main Jul 17, 2023
60 checks passed
@emmyoop emmyoop deleted the er/datadog-env-vars branch July 17, 2023 22:19
emmyoop added a commit that referenced this pull request Jul 18, 2023
@emmyoop
add datadog env vars (#829)
9bd51ee
emmyoop added a commit that referenced this pull request Jul 18, 2023
@emmyoop
add datadog env vars (#829)
91f68e4
emmyoop added a commit that referenced this pull request Jul 18, 2023
@emmyoop
add datadog env vars (#829)
7c02078
emmyoop added a commit that referenced this pull request Jul 18, 2023
@emmyoop
add datadog env vars (#829)
61c40d1 
# Conflicts:
#	dev-requirements.txt
#	tox.ini
emmyoop added a commit that referenced this pull request Jul 18, 2023
@emmyoop
add datadog env vars (#829)
552db1c 
# Conflicts:
#	.github/workflows/integration.yml
#	dev-requirements.txt
#	tox.ini
This was referenced Jul 18, 2023
Merged
Merged
Merged
Merged
Merged
emmyoop added a commit that referenced this pull request Jul 20, 2023
@emmyoop
add datadog env vars (#829) (#836)
e0529a2
emmyoop added a commit that referenced this pull request Jul 20, 2023
@emmyoop
add datadog env vars (#829) (#837)
a8e7ad7
emmyoop added a commit that referenced this pull request Jul 20, 2023
@emmyoop
add datadog env vars (#829) (#835)
4de9484
emmyoop added a commit that referenced this pull request Jul 20, 2023
@emmyoop
add datadog env vars (#829) (#834)
2201ca7 
# Conflicts:
#	dev-requirements.txt
#	tox.ini
emmyoop added a commit that referenced this pull request Jul 20, 2023
@emmyoop
add datadog env vars (#829) (#833)
5499e04 
# Conflicts:
#	.github/workflows/integration.yml
#	dev-requirements.txt
#	tox.ini
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Apr 24, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikealfare mikealfare mikealfare approved these changes

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emmyoop @mikealfare