Feat/generate sources add database and schema #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyholtzman
force-pushed
the
feat/generate_sources_add_database_and_schema
branch
2 times, most recently
from
6cecf1c to
de916e9
Compare
jeremyholtzman
force-pushed
the
feat/generate_sources_add_database_and_schema
branch
from
de916e9 to
45135da
Compare
dbeatty10
requested changes
May 1, 2023
There was a problem hiding this comment.
Now that we're aligned on the behavior described in #123 (comment), we can tackle all the implementation details 🚀
Can you do each of the following before we dive any deeper into the code review?
- Remove any code formatting not related to the actual implementation of the new feature
- Use the following two (shorter) parameter names:
include_databaseinclude_schema
More detail
There appear to be a lot of unnecessary code formatting, so I didn't go through and make code suggestions for each. You'll be able to tell if you caught them all if the diff shown within the pull request is minimal.
|
@dbeatty10 Thanks Doug, just made the updates you mentioned! |
dbeatty10
reviewed
May 1, 2023
dbeatty10
approved these changes
May 1, 2023
There was a problem hiding this comment.
Looks great @jeremyholtzman -- thanks for all your work on this!
2 tasks
gwenwindflower
deleted the
feat/generate_sources_add_database_and_schema
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #123
This is a:
Description & motivation
Checklist