Feature/generate_source_descs_iss64 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-winkler
approved these changes
Jun 10, 2022
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
dbeatty10
reviewed
Jun 22, 2022
Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
jeremyholtzman
pushed a commit
that referenced
this pull request
Apr 10, 2023
* update generate_source.sql to add descriptions for table/source and name arg * add integration tests * fix test * update all args source test * changelog * Update macros/generate_source.sql Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * Update README.md Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * moved name to end up arguments block in readme * Update integration_tests/tests/test_generate_source_all_args.sql Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * move name to last arg in test_generate_source_all_args Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
maindev/branchdev/branchDescription & motivation
Currently, generate_source has an option to set include_descriptions = True, but this parameters only includes descriptions at the column level. Ideally, description placeholders would also be generated for the source and tables as well. Additionally, the required parameter for generate_source macro is the schema name, but there is no option to input a name value. It is possible that a user would like to name their source a different name from the schema name. See issue
Checklist