added comments to verbose regex in generate_model_import_ctes #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-per
approved these changes
Dec 2, 2022
|
Blessings upon you ❤️
If this becomes necessary, please consider turning them into get_XXXX_regex() macros instead of copy-pasting them around. |
joellabes
approved these changes
Dec 5, 2022
jeremyholtzman
pushed a commit
that referenced
this pull request
Apr 10, 2023
added comments to verbose regex in generate_model_import_ctes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a:
maindev/branchdev/branchDescription & motivation
Closes #91 - increases readability of generate_model_import_ctes.sql by using VERBOSE mode for regex and explanatory comments
Checklist