-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI workflow #15
Add CI workflow #15
Conversation
3eb228a
to
9c69956
Compare
25b342e
to
6d91ff5
Compare
.github/workflows/build.yml
Outdated
# TODO: how to validate here? we did dbt --version previously... | ||
- name: "Check wheel distributions" | ||
run: | | ||
pip freeze |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
perhaps: pip freeze | grep dbt-common
? it should return a non-zero exit code if no match is found. e.g.
❯ pip freeze | grep requests
❯ echo $?
1
❯ pip freeze | grep dbt-common
dbt-common @ file:///Users/michelleark/src/dbt-common
❯ echo $?
0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! We can look into adding additional checks (e.g. mypy) to the pre-commit config but that can be done on the base PR. Here are the dbt-semantic-interfaces checks for reference: https://github.com/dbt-labs/dbt-semantic-interfaces/blob/main/.pre-commit-config.yaml
Agree. The code quality check will just run anything we set up in the config so we can play with it on the other branch. |
resolves #12
targetting
copy-code-from-dbt-core
since thats where the tests existtesting, code quality and build are all separate. The build workflow is just a stub until we decide on the build tool. We can use it to both test the build works during regularly run CI as well as for the release process if needed.
Left to do
Setting up code coverage. will do as part of Set up codecov in CI #16