Fix #9608: Unit test fixture compilation

dbt-labs · Mar 22, 2024 · 68c7cb4 · 68c7cb4
1 parent 2c1926c
commit 68c7cb4
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/core/dbt/contracts/graph/nodes.py b/core/dbt/contracts/graph/nodes.py
@@ -2,6 +2,7 @@
 from datetime import datetime
 from dataclasses import dataclass, field
 import hashlib
+from pathlib import Path
 
 from mashumaro.types import SerializableType
 from typing import (
@@ -954,15 +955,10 @@ class UnitTestDefinition(NodeInfoMixin, GraphNode, UnitTestDefinitionResource):
     def resource_class(cls) -> Type[UnitTestDefinitionResource]:
         return UnitTestDefinitionResource
 
-    @property
-    def build_path(self):
-        # TODO: is this actually necessary?
-        return self.original_file_path
-
     @property
     def compiled_path(self):
-        # TODO: is this actually necessary?
-        return self.original_file_path
+        path = Path(self.original_file_path).parent / (self.name + ".sql")
+        return str(self.original_file_path / path)
 
     @property
     def depends_on_nodes(self):

diff --git a/core/dbt/parser/unit_tests.py b/core/dbt/parser/unit_tests.py
@@ -123,7 +123,7 @@ def parse_unit_test_case(self, test_case: UnitTestDefinition):
 
             common_fields = {
                 "resource_type": NodeType.Model,
-                "original_file_path": original_input_node.original_file_path,
+                "original_file_path": unit_test_node.original_file_path,
                 "config": ModelConfig(materialized="ephemeral"),
                 "database": original_input_node.database,
                 "alias": original_input_node.identifier,
@@ -144,7 +144,8 @@ def parse_unit_test_case(self, test_case: UnitTestDefinition):
                     package_name=original_input_node.package_name,
                     unique_id=f"model.{original_input_node.package_name}.{input_name}",
                     name=input_name,
-                    path=original_input_node.path or f"{input_name}.sql",
+                    # models/my_model.yml/models/my_unit_test.sql
+                    path=os.path.join(unit_test_node.original_file_path, unit_test_node.path),
                 )
                 if (
                     original_input_node.resource_type == NodeType.Model

diff --git a/core/dbt/task/printer.py b/core/dbt/task/printer.py
@@ -105,7 +105,7 @@ def print_run_result_error(result, newline: bool = True, is_warning: bool = Fals
         else:
             fire_event(RunResultErrorNoMessage(status=result.status))
 
-        if result.node.build_path is not None:
+        if result.node.compiled_path is not None:
             with TextOnly():
                 fire_event(Formatting(""))
             fire_event(SQLCompiledPath(path=result.node.compiled_path))