Skip to content

Commit

Permalink
Fix test failures (#8432)
Browse files Browse the repository at this point in the history
* fail job when anything fails in previous matrix

* tweak wording

* PR feedback
  • Loading branch information
emmyoop authored Aug 17, 2023
1 parent 37a2907 commit 770f804
Showing 1 changed file with 10 additions and 2 deletions.
12 changes: 10 additions & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -227,13 +227,21 @@ jobs:
flags: integration

integration-report:
if: ${{ always() }}
name: Integration Test Suite
runs-on: ubuntu-latest
needs: integration
steps:
- name: "[Notification] Integration test suite passes"
- name: "Integration Tests Failed"
if: ${{ contains(needs.integration.result, 'failure') || contains(needs.integration.result, 'cancelled') }}
# when this is true the next step won't execute
run: |
echo "::notice title="Integration test suite passes""
echo "::notice title='Integration test suite failed'"
exit 1
- name: "Integration Tests Passed"
run: |
echo "::notice title='Integration test suite passed'"
build:
name: build packages
Expand Down

0 comments on commit 770f804

Please sign in to comment.