use frozenset for adapter specific configs, add bq configs

dbt-labs · Feb 11, 2019 · ab6d4d7 · ab6d4d7
1 parent 8212994
commit ab6d4d7
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 3 deletions.
diff --git a/core/dbt/adapters/base/impl.py b/core/dbt/adapters/base/impl.py
@@ -110,7 +110,9 @@ class BaseAdapter(object):
     # This should be an implementation of BaseConnectionManager
     ConnectionManager = None
 
-    AdapterSpecificConfigs = set()
+    # A set of clobber config fields accepted by this adapter
+    # for use in materializations
+    AdapterSpecificConfigs = frozenset()
 
     def __init__(self, config):
         self.config = config

diff --git a/plugins/bigquery/dbt/adapters/bigquery/impl.py b/plugins/bigquery/dbt/adapters/bigquery/impl.py
@@ -51,6 +51,8 @@ class BigQueryAdapter(BaseAdapter):
     Column = dbt.schema.BigQueryColumn
     ConnectionManager = BigQueryConnectionManager
 
+    AdapterSpecificConfigs = frozenset({"cluster_by", "partition_by"})
+
     ###
     # Implementations of abstract methods
     ###

diff --git a/plugins/redshift/dbt/adapters/redshift/impl.py b/plugins/redshift/dbt/adapters/redshift/impl.py
@@ -7,7 +7,7 @@
 class RedshiftAdapter(PostgresAdapter):
     ConnectionManager = RedshiftConnectionManager
 
-    AdapterSpecificConfigs = {"sort_type", "dist", "sort", "bind"}
+    AdapterSpecificConfigs = frozenset({"sort_type", "dist", "sort", "bind"})
 
     @classmethod
     def date_function(cls):

diff --git a/plugins/snowflake/dbt/adapters/snowflake/impl.py b/plugins/snowflake/dbt/adapters/snowflake/impl.py
@@ -14,7 +14,7 @@ class SnowflakeAdapter(SQLAdapter):
     Relation = SnowflakeRelation
     ConnectionManager = SnowflakeConnectionManager
 
-    AdapterSpecificConfigs = {"transient"}
+    AdapterSpecificConfigs = frozenset({"transient"})
 
     @classmethod
     def date_function(cls):