Skip to content

Commit

Permalink
loosen the click pin (#8232) (#8252)
Browse files Browse the repository at this point in the history
* loosen the click pin

* changelog

* separate out sqlparse pin

* remove changelog

* add ignores

Co-authored-by: Grace Goheen <53586774+graciegoheen@users.noreply.github.com>
  • Loading branch information
emmyoop and graciegoheen authored Aug 15, 2023
1 parent 4b21acd commit dd7a329
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
6 changes: 6 additions & 0 deletions .changes/unreleased/Dependencies-20230727-145703.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Dependencies
body: Update pin for click<9
time: 2023-07-27T14:57:03.180458-05:00
custom:
Author: emmyoop
PR: "8232"
6 changes: 3 additions & 3 deletions core/dbt/cli/params.py
Original file line number Diff line number Diff line change
Expand Up @@ -380,9 +380,9 @@
# Most CLI arguments should use the combined `select` option that aliases `--models` to `--select`.
# However, if you need to split out these separators (like `dbt ls`), use the `models` and `raw_select` options instead.
# See https://github.com/dbt-labs/dbt-core/pull/6774#issuecomment-1408476095 for more info.
models = click.option(*model_decls, **select_attrs)
raw_select = click.option(*select_decls, **select_attrs)
select = click.option(*select_decls, *model_decls, **select_attrs)
models = click.option(*model_decls, **select_attrs) # type: ignore[arg-type]
raw_select = click.option(*select_decls, **select_attrs) # type: ignore[arg-type]
select = click.option(*select_decls, *model_decls, **select_attrs) # type: ignore[arg-type]

selector = click.option(
"--selector",
Expand Down
2 changes: 1 addition & 1 deletion core/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"Jinja2==3.1.2",
"agate>=1.6,<1.7.1",
# temporarily pinning click for mypy failures: https://github.com/pallets/click/issues/2558
"click>=7.0,<8.1.4",
"click<9",
"colorama>=0.3.9,<0.4.7",
"hologram>=0.0.14,<=0.0.16",
"isodate>=0.6,<0.7",
Expand Down

0 comments on commit dd7a329

Please sign in to comment.