Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow configuration of snapshot column names #10608

Merged
merged 30 commits into from
Sep 20, 2024
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Aug 26, 2024

Resolves #10185

Problem

We hardcode the column names in snapshot tables.

Solution

Allow configuring column names.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner August 26, 2024 19:22
@cla-bot cla-bot bot added the cla:yes label Aug 26, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.00%. Comparing base (7016cd3) to head (c71f9d5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10608      +/-   ##
==========================================
+ Coverage   88.96%   89.00%   +0.03%     
==========================================
  Files         181      181              
  Lines       22975    22956      -19     
==========================================
- Hits        20439    20431       -8     
+ Misses       2536     2525      -11     
Flag Coverage Δ
integration 86.25% <100.00%> (+0.11%) ⬆️
unit 62.44% <93.75%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.44% <93.75%> (+0.04%) ⬆️
Integration Tests 86.25% <100.00%> (+0.11%) ⬆️

@gshank gshank closed this Aug 27, 2024
@gshank gshank reopened this Aug 27, 2024
@gshank gshank closed this Sep 13, 2024
@gshank gshank reopened this Sep 13, 2024
@gshank gshank closed this Sep 13, 2024
@gshank gshank reopened this Sep 13, 2024
@gshank gshank closed this Sep 13, 2024
@gshank gshank reopened this Sep 13, 2024
@gshank gshank requested a review from a team as a code owner September 16, 2024 13:08
@gshank gshank requested review from jzhu13 and removed request for a team September 16, 2024 13:08
@gshank gshank closed this Sep 18, 2024
@gshank gshank reopened this Sep 18, 2024
Copy link
Contributor

@peterallenwebb peterallenwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@@ -1,7 +1,7 @@
git+https://github.com/dbt-labs/dbt-adapters.git@main
git+https://github.com/dbt-labs/dbt-adapters.git@main#subdirectory=dbt-tests-adapter
git+https://github.com/dbt-labs/dbt-adapters.git@snapshot_column_names
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's obvious, but I'm just leaving a reminder that these changes will need to be left out of the merge.

@gshank gshank merged commit db69473 into main Sep 20, 2024
60 of 62 checks passed
@gshank gshank deleted the snapshot_column_names branch September 20, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow customizing names of metadata fields in snapshots
3 participants