-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow configuration of snapshot column names #10608
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10608 +/- ##
==========================================
+ Coverage 88.96% 89.00% +0.03%
==========================================
Files 181 181
Lines 22975 22956 -19
==========================================
- Hits 20439 20431 -8
+ Misses 2536 2525 -11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
dev-requirements.txt
Outdated
@@ -1,7 +1,7 @@ | |||
git+https://github.com/dbt-labs/dbt-adapters.git@main | |||
git+https://github.com/dbt-labs/dbt-adapters.git@main#subdirectory=dbt-tests-adapter | |||
git+https://github.com/dbt-labs/dbt-adapters.git@snapshot_column_names |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's obvious, but I'm just leaving a reminder that these changes will need to be left out of the merge.
Resolves #10185
Problem
We hardcode the column names in snapshot tables.
Solution
Allow configuring column names.
Checklist