-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support console env var DO_NOT_TRACK #3540
Comments
@sethwoodworth Thanks for opening the issue! This sounds like a great standard to follow. I'd be interested in supporting this via two env vars:
Ultimately, I'd like for every runtime config to have an associated flag, profile config, and env var, as outlined in #2990. In any case, I'd welcome a contribution for this. |
We've implemented this as Many of the issues/PRs linked from https://consoledonottrack.com/ seem to have gotten ... quite heated ... and were ultimately closed, but I don't see a really good reason to oppose adding/aliasing the same functionality with |
…rue` (#4713) ## What are you changing in this pull request and why? While responding to dbt-labs/dbt-core#9336, I set `DO_NOT_TRACK=0` and examined the result. It does not behave the same way as `DBT_SEND_ANONYMOUS_USAGE_STATS=True`. Looking at the source code [here](https://github.com/dbt-labs/dbt-core/blob/11cc71b75fa64b09888461339eb1eb3b394f9528/core/dbt/cli/flags.py#L252-L254) explains why. So we can safely just remove this line from the docs for [`send_anonymous_usage_stats`](https://docs.getdbt.com/reference/global-configs/usage-stats) to avoid confusion. ## Additional info We first added support for the [Console Do Not Track](https://consoledonottrack.com/) initiative within dbt-labs/dbt-core#5000 as described in dbt-labs/dbt-core#3540. Any of the following are equivalent to `DBT_SEND_ANONYMOUS_USAGE_STATS=False` (whether they are uppercase, lowercase, or mixed case): ``` export DO_NOT_TRACK=1 export DO_NOT_TRACK=t export DO_NOT_TRACK=true export DO_NOT_TRACK=y export DO_NOT_TRACK=yes ``` Any other values of `DO_NOT_TRACK` are ignored altogether and not have any effect. ## Checklist - [x] Review the [Content style guide](https://github.com/dbt-labs/docs.getdbt.com/blob/current/contributing/content-style-guide.md) so my content adheres to these guidelines.
Describe the feature
If the console environment variable
DO_NOT_TRACK
is set (to any value), do not send anonymous usage stats. The current configuration equivalent is in~/.dbt/profiles.yml
The website promoting and documenting the standard is: https://consoledonottrack.com/
Describe alternatives you've considered
The current yaml config: send_anonymous_usage_stats serves the same purpose, but is specific to DBT, where
DO_NOT_TRACK
is intended to be universal.Who will this benefit?
Users who would like to avoid sending usage statistics by default would no longer need to:
Are you interested in contributing this feature?
Yes, I would be more than willing to implement the feature if the issue is accepted.
The text was updated successfully, but these errors were encountered: