Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update log levels for partial parsing #3886

Closed
jtcohen6 opened this issue Sep 15, 2021 · 0 comments · Fixed by #3889
Closed

Update log levels for partial parsing #3886

jtcohen6 opened this issue Sep 15, 2021 · 0 comments · Fixed by #3889
Assignees
Labels
enhancement New feature or request partial_parsing

Comments

@jtcohen6
Copy link
Contributor

jtcohen6 commented Sep 15, 2021

When we turn on partial parsing by default (#3867), I think we should update log levels for partial parsing messages so that:

  • When partial parsing works, those messages (Partial parsing enabled) are debug level
  • When partial parsing does not work, keep those messages at info level
  • Reword the "cold parse" message to make it clearer what's going on: Unable to do partial parsing because target/partial_parse.msgpack not foundPartial parse save file not found. Starting full parse (or something like that), to avoid user confusion e.g. Slack thread
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request partial_parsing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants