Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate catalog for relational, non-ephemeral nodes only #3920

Closed
jtcohen6 opened this issue Sep 18, 2021 · 0 comments · Fixed by #3922
Closed

Generate catalog for relational, non-ephemeral nodes only #3920

jtcohen6 opened this issue Sep 18, 2021 · 0 comments · Fixed by #3922
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!

Comments

@jtcohen6
Copy link
Contributor

Similar to what #3716 did for schema caching, we should do for cataloging, too. If we expect a node to exist as an object in the database, add its database-schema to the set of namespaces to catalog; if it's ephemeral or otherwise non-relational, ignore it.

I think this would be as simple as updating the logic in _get_catalog_schemas to check for node.is_relational and not node.is_ephemeral_model, as we do in _get_cache_schemas:

https://github.com/dbt-labs/dbt/blob/05dea18b625253625c135cbf37311d0206a8cc79/core/dbt/adapters/base/impl.py#L316-L337

@jtcohen6 jtcohen6 added enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors! labels Sep 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good_first_issue Straightforward + self-contained changes, good for new contributors!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant