Feature/catalog relational objects #3922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
approved these changes
Sep 23, 2021
…ure/catalog-relational-objects
jtcohen6
approved these changes
Sep 23, 2021
1 task
1 task
iknox-fa
pushed a commit
that referenced
this pull request
Feb 8, 2022
* filter to relational nodes * cleanup * flake formatting * changelog automatic commit by git-black, original commits: f4f5d31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #3920
Description
This PR changes the base behavior for generating the map of schemas used in the
dbt docs generatestep to only those that contain relational, non-ephemeral nodes. Current behavior checks all nodes, which includes tests, and can result in errors when used in conjunction with customgenerate_database_namebehavior in a project.Note: when
store_failuresis set to true, this logic will interpret tests as relational nodes, and therefore can trigger a similar error depending on the defaultgenerate_database_namebehavior in the project.Checklist
CHANGELOG.mdand added information about my change to the "dbt next" section.