Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-621] Turn on mypy strict flag #5225

Open
Tracked by #8387
nathaniel-may opened this issue May 9, 2022 · 1 comment
Open
Tracked by #8387

[CT-621] Turn on mypy strict flag #5225

nathaniel-may opened this issue May 9, 2022 · 1 comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality

Comments

@nathaniel-may
Copy link
Contributor

nathaniel-may commented May 9, 2022

#5171 upgraded mypy to the latest version and changed it to run it on the entire codebase. This ticket is to turn on the --strict flag which dramatically increases the enforced level of code quality.

This will take a large effort to convert the existing code to comply with the strict flag, and should be done iteratively where possible. One strategy would be to run mypy in CI twice: once on as we currently do, and once with the strict flag on a small subset of the codebase that can be expanded with subsequent PRs. Following Imports may make this strategy limiting.

@nathaniel-may nathaniel-may added the tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality label May 9, 2022
@github-actions github-actions bot changed the title Turn on mypy strict flag [CT-621] Turn on mypy strict flag May 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2022

This issue has been marked as Stale because it has been open for 180 days with no activity. If you would like the issue to remain open, please remove the stale label or comment on the issue, or it will be closed in 7 days.

@github-actions github-actions bot added the stale Issues that have gone stale label Nov 6, 2022
@leahwicz leahwicz removed the stale Issues that have gone stale label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech_debt Behind-the-scenes changes, with little direct impact on end-user functionality
Projects
None yet
Development

No branches or pull requests

2 participants