Update mypy to latest and turn on everywhere #5171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
iknox-fa
commented
Apr 27, 2022
| @@ -140,8 +140,6 @@ def get_adapter_plugins(self, name: Optional[str]) -> List[AdapterPlugin]: | |||
| raise InternalException(f"No plugin found for {plugin_name}") from None | |||
| plugins.append(plugin) | |||
| seen.add(plugin_name) | |||
| if plugin.dependencies is None: | |||
There was a problem hiding this comment.
@VersusFacit This works right? From what I can see here plugin.dependencies will never be None.
iknox-fa
commented
Apr 27, 2022
iknox-fa
commented
Apr 27, 2022
iknox-fa
commented
Apr 27, 2022
1 task
leahwicz
reviewed
May 2, 2022
sungchun12
approved these changes
May 5, 2022
leahwicz
approved these changes
May 5, 2022
1 task
This was referenced May 9, 2022
Closed
agoblet
pushed a commit
to BigDataRepublic/dbt-core
that referenced
this pull request
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #4805 #4089
Description
Checklist
changie newto create a changelog entry