Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CT-2721] [Feature] support specify partial parsing file location #7911

Closed
3 tasks done
ChenyuLInx opened this issue Jun 20, 2023 · 3 comments · Fixed by #8032
Closed
3 tasks done

[CT-2721] [Feature] support specify partial parsing file location #7911

ChenyuLInx opened this issue Jun 20, 2023 · 3 comments · Fixed by #8032
Assignees
Labels
enhancement New feature or request

Comments

@ChenyuLInx
Copy link
Contributor

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

All inputs for dbt-core should be configurable independently, with sane default when necessary. This makes running dbt-core on cloud easier to reason about. Because you can clearly configure all of your input for a dbt invocation.

Currently dbt-core will try to load up partial_parse.msgpack from the target dir(link). There's no way to configure it without configure target dir to the same place.

We should provide a parameter(for all commands that does parsing) to being able to specify location to load partial_parse.msgpack, and if not specified dbt-core will fall back to use the current target dir.

Describe alternatives you've considered

Not do anything.

Who will this benefit?

No response

Are you interested in contributing this feature?

No response

Anything else?

No response

@ChenyuLInx ChenyuLInx added enhancement New feature or request triage labels Jun 20, 2023
@github-actions github-actions bot changed the title [Feature] support specify partial parsing file location [CT-2721] [Feature] support specify partial parsing file location Jun 20, 2023
@jtcohen6 jtcohen6 removed the triage label Jun 21, 2023
@jtcohen6
Copy link
Contributor

@ChenyuLInx Given how internal this is to dbt-core, I'd love if there were a way to support configuring this without another flag/parameter. Ideas:

@ChenyuLInx
Copy link
Contributor Author

ChenyuLInx commented Jun 30, 2023

@jtcohen6 How does create hidden parameter like what we do for deprecated params sounds?
User don't get it from the help text(they could use it if they really want). And it follows our existing patterns.

@jtcohen6
Copy link
Contributor

jtcohen6 commented Jul 3, 2023

@ChenyuLInx Adding this as a parameter with hidden=true feels like a reasonable compromise. Let's do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants