compile --no-inject-ephemeral-ctes flag

[benmosher]

...for inline compilation of models during linting only.

resolves #8480

Problem

Injection of ephemeral model CTEs breaks SQLFluff linting in Cloud.

Solution

Optionally suppressing the injection of CTEs (intentionally added to the compile command only!) enables SQLFluff linting of models with direct ephemeral model references.

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
• Revalidate in an IDE session

[cla-bot]

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @benmosher

[codecov]

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (4ec87a0) 86.36% compared to head (1235de1) 86.37%.
Report is 19 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8482      +/-   ##
==========================================
+ Coverage   86.36%   86.37%   +0.01%     
==========================================
  Files         174      174              
  Lines       25575    25591      +16     
==========================================
+ Hits        22087    22104      +17     
+ Misses       3488     3487       -1     

Flag	Coverage Δ
integration	83.18% <100.00%> (-0.03%)	⬇️
unit	65.04% <50.00%> (-0.12%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed	Coverage Δ
core/dbt/cli/main.py	98.69% <100.00%> (+<0.01%)	⬆️
core/dbt/cli/params.py	100.00% <100.00%> (ø)
core/dbt/compilation.py	96.19% <100.00%> (+0.02%)	⬆️

... and 33 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dbeatty10]

@cla-bot check

[cla-bot]

The cla-bot has been summoned, and re-checked this pull request!

[benmosher]

@MichelleArk -- I see your 👀; I left this in draft because the last checkbox is unchecked but it's otherwise ready to go AFAIK. anything else I should do?

[MichelleArk]

@benmosher - with regards to that last checkbox, @graciegoheen will be helping out with this review from the Product perspective so we can get approval on that front before merging :)

[graciegoheen]

Let's hide the flag from the CLI --help text, since I think it will be confusing clutter for 99% of end users. Same as we did for #7911

[benmosher]

@graciegoheen agreed! I believe I've hidden it via this hidden=True 👍

[benmosher]

I'd like to revalidate this in the ide-server before merging after changing the flag name. Should be fine since the test still passes but just want to be sure!

[benmosher]

Revalidation complete 👍

[MichelleArk]

🚢 🇮🇹

[benmosher]

@MichelleArk I think you need to push the button -- I'm not authorized to merge to Core 😅