Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SL] Add cache configuration to SavedQuery config #9540

Closed
1 task done
Tracked by #9116
QMalcolm opened this issue Feb 8, 2024 · 0 comments · Fixed by #9588
Closed
1 task done
Tracked by #9116

[SL] Add cache configuration to SavedQuery config #9540

QMalcolm opened this issue Feb 8, 2024 · 0 comments · Fixed by #9588
Assignees
Labels
enhancement New feature or request Impact: CA Impact: SL user docs [docs.getdbt.com] Needs better documentation
Milestone

Comments

@QMalcolm
Copy link
Contributor

QMalcolm commented Feb 8, 2024

Housekeeping

  • I am a maintainer of dbt-core

Short description

The SavedQuery config is getting a new top level property, cache. This is to to enable semantic layer implementations to setup caching as they see fit. This is being added to the dbt-semantic-interfaces protocol definitions in dbt-labs/dbt-semantic-interfaces#252. The value for the cache key is an object with one attribute (currently) enabled which is either true or false.

Acceptance criteria

  • cache can optionally be specified in the config of SavedQuerys
  • if cache is specified for SavedQuerys in a dbt_project.toml, it is properly inherited
  • if a cache isn't specified, a default cache object is still created with enabled = false

Suggested Tests

  • cache can be specified in a SavedQuery config
  • cache can be specified for a SavedQuery config via the dbt_project.toml
  • the cache defined in yaml for the SavedQuery overrides settings from the dbt_project.toml
  • if no cache is specified, a default one is supplied with enabled = false

Impact to Other Teams

Affects the Cloud Artifacts team as new properties will be present
Affects the Semantic Layer team as they need this to be able to implement functionality

Will backports be required?

No

Context

No response

@QMalcolm QMalcolm added user docs [docs.getdbt.com] Needs better documentation Impact: CA Impact: SL labels Feb 8, 2024
@martynydbt martynydbt added this to the v1.8 milestone Feb 8, 2024
@martynydbt martynydbt added the enhancement New feature or request label Feb 12, 2024
@QMalcolm QMalcolm changed the title [SL] Add cache configuration to Export configurations of SavedQuery [SL] Add cache configuration to SavedQuery config Feb 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Impact: CA Impact: SL user docs [docs.getdbt.com] Needs better documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants