Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs Changes Needed from dbt-core PR #9588 #4946

Closed
FishtownBuildBot opened this issue Feb 16, 2024 · 2 comments · Fixed by #5021
Closed

Docs Changes Needed from dbt-core PR #9588 #4946

FishtownBuildBot opened this issue Feb 16, 2024 · 2 comments · Fixed by #5021
Assignees
@mirnawong1
Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear
Milestone
dbt Core v1.8 Doc...

Comments

@FishtownBuildBot
Copy link

FishtownBuildBot commented Feb 16, 2024 •
edited by emmyoop
Loading

The SavedQuery config now accepts cache with enabled: True or enabled: False. If not defined, it defaults to a value of false.

saved_queries:
  - name: test_saved_query
    description: "{{ doc('saved_query_description') }}"
    label: Test Saved Query
    config:
      cache:
        enabled: True
    query_params:
        metrics:
            - simple_metric
        group_by:
            - "Dimension('user__ds')"
        where:
            - "{{ Dimension('user__ds', 'DAY') }} <= now()"
            - "{{ Dimension('user__ds', 'DAY') }} >= '2023-01-01'"
    exports:
        - name: my_export
          config:
            alias: my_export_alias
            export_as: table
            schema: my_export_schema_name

More details in dbt-labs/dbt-core#9540 and pending changes in SL for dbt-labs/dbt-semantic-interfaces#252
@FishtownBuildBot FishtownBuildBot mentioned this issue Feb 16, 2024
Merged
5 tasks
@runleonarun runleonarun added content Improvements or additions to content improvement Use this when an area of the docs needs improvement as it's currently unclear dbt Core The changes proposed in this issue relate to dbt Core labels Feb 16, 2024
@mirnawong1
Copy link
Contributor

hey @Jstein77 - is this ready for me to add here?

@mirnawong1 mirnawong1 self-assigned this Feb 28, 2024
@runleonarun runleonarun added this to the dbt Core Documentation milestone Feb 29, 2024
@mirnawong1 mirnawong1 mentioned this issue Feb 29, 2024
Merged
@mirnawong1
Copy link
Contributor

hey @QMalcolm , i've added this to the v1.8 milestone as it looks like these are v1.8-related. let me know if that isn't right though 🙏 !

mirnawong1 added a commit that referenced this issue Mar 14, 2024
@mirnawong1
add cache to SQ config (#5021)
b141ebe 
this pr addresses issue 4946 and adds `cache` to the `SavedQuery` config
in the SQ page.

Added version blocks as it seems this new update is for 1.8 release but
confirming in
[slack](https://dbt-labs.slack.com/archives/C03SK9W08BC/p1709217805116339)

Resolves #4946
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirnawong1 mirnawong1

Labels
content Improvements or additions to content dbt Core The changes proposed in this issue relate to dbt Core improvement Use this when an area of the docs needs improvement as it's currently unclear
Projects
None yet
Milestone
dbt Core v1.8 Documentation
Development

Successfully merging a pull request may close this issue.

add cache to SQ config dbt-labs/docs.getdbt.com
3 participants
@runleonarun @FishtownBuildBot @mirnawong1