-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
empty unit test csv fixture values default to null #10117
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
@@ -1822,7 +1822,7 @@ def code(self) -> str: | |||
return "Z026" | |||
|
|||
def message(self) -> str: | |||
return f" compiled Code at {self.path}" | |||
return f" compiled code at {self.path}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small formatting issue, unrelated to the behaviour changes in this PR
cc @jtcohen6
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10117 +/- ##
==========================================
+ Coverage 88.16% 88.19% +0.02%
==========================================
Files 181 181
Lines 22771 22788 +17
==========================================
+ Hits 20077 20097 +20
+ Misses 2694 2691 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-10117-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 55aad328ea6878ca8bbc5dc53fb734b6142c0ec7
# Push it to GitHub
git push --set-upstream origin backport-10117-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest Then, create a pull request where the |
(cherry picked from commit 55aad32)
resolves #9881
Problem
CSV fixtures with empty values are converted to "" instead of null -- which is inconsistent with the way seeds work.
Solution
_validate_and_normalize_rows
Checklist