-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Print and use event system #10131
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
552e123
to
03a5344
Compare
@ChenyuLInx to my knowledge, we only use |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10131 +/- ##
==========================================
+ Coverage 88.58% 88.63% +0.04%
==========================================
Files 180 180
Lines 22436 22435 -1
==========================================
+ Hits 19876 19885 +9
+ Misses 2560 2550 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
resolves #8756
Need dbt-labs/dbt-common#130
Problem
We want to have some event that
would still output to stdout when --quiet is specified,
without the timestamps in front
This PR does so by creating a specific event in dbt-common and implemented logic to have this event always passed to logger as 'error' level.
Solution
Switch to use the PrintEvent
Currently only downside is the original ListCmdOut event is being swapped to PrintEvent when log format is json.
info.code
andinfo.name
are changed.@benmosher do you know if IDE rely on this somehow?
previously it was
TODO
Checklist