Reorganize tests to match their code location #10191
Conversation
| from tests.unit.utils import ContractTestCase | ||
|
|
||
|
|
||
| class TestUnparsedMacro(ContractTestCase): |
There was a problem hiding this comment.
moved from test_contracts_graph_unparsed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10191 +/- ##
==========================================
- Coverage 88.63% 88.57% -0.07%
==========================================
Files 180 180
Lines 22434 22434
==========================================
- Hits 19885 19870 -15
- Misses 2549 2564 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tests/unit/test_graph_selection.py
Outdated
There was a problem hiding this comment.
Moved to graph/test_selectors.py
There was a problem hiding this comment.
Not sure why this does not show up in the file view, but this file does exists
There was a problem hiding this comment.
moved to graph/test_selector_spec.py
tests/unit/test_infer_primary_key.py
Outdated
There was a problem hiding this comment.
moved to graph/test_nodes.py
tests/unit/test_inject_ctes.py
Outdated
There was a problem hiding this comment.
moved to contracts/graph/test_nodes.py
There was a problem hiding this comment.
moved to config/test_selectors.py
tests/unit/test_semver.py
Outdated
There was a problem hiding this comment.
moving to dbt-common pr
There was a problem hiding this comment.
Moved to contracts/graph/test_unparsed.py
tests/unit/clients/test_jinja.py
Outdated
There was a problem hiding this comment.
This we converted from unit test to pytest
tests/unit/clients/test_jinja.py
Outdated
There was a problem hiding this comment.
changing from unit test to pytest
tests/unit/config/test_selectors.py
Outdated
There was a problem hiding this comment.
consolidated test_manifest_selectors.py to this file
There was a problem hiding this comment.
Consolidated test_inject_ctes.py to this file
tests/unit/graph/test_nodes.py
Outdated
There was a problem hiding this comment.
Consolidated test_infer_primary_key.py to this file
There was a problem hiding this comment.
Moved from test_graph_selector_spec.py
There was a problem hiding this comment.
moved to contracts/graph/test_unparsed.py
There was a problem hiding this comment.
moved to graph/test_selector_spec.py
tests/unit/test_infer_primary_key.py
Outdated
There was a problem hiding this comment.
moved to graph/test_nodes.py
tests/unit/test_inject_ctes.py
Outdated
There was a problem hiding this comment.
Moved to contracts/graph/test_nodes.py
There was a problem hiding this comment.
Moved to config/test_selectors.py
tests/unit/test_semver.py
Outdated
There was a problem hiding this comment.
moved to dbt-common
| @@ -55,8 +55,7 @@ | |||
| ) | |||
There was a problem hiding this comment.
I think an argument could be made that these tests should be moved into other files. There are config tests that should probably exist in /tests/unit/contracts/graph/test_model_config.py and the rest can probably be moved to /tests_unit_contracts/graph/test_nodes.py. However perhaps that should be a follow up task given this file is 2347 lines long
resolves ##9961
Problem
Our unit test does not match the code location. This makes finding example unit tests harder.
Solution
We are moving all unit tests to match the code location they are at.