Render more config fields (#960) #1033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmcarthur
requested changes
Oct 8, 2018
dbt/config.py
Outdated
|
|
||
| @staticmethod | ||
| def _is_port_path(keypath): | ||
| return len(keypath) == 2 and keypath[-1] == 'port' |
dbt/config.py
Outdated
| if len(keypath) != 4: | ||
| return value | ||
|
|
||
| if keypath[-1] == 'port' and keypath[1] == 'outputs': |
There was a problem hiding this comment.
i assume you meant to use _is_port_path here.
this is ok for now. thought: this should be on the adapter as part of "Adapters as Plugins"
dbt/config.py
Outdated
| return len(keypath) == 2 and keypath[-1] == 'port' | ||
|
|
||
| @staticmethod | ||
| def _convert_port(value, keypath): |
There was a problem hiding this comment.
oh... it looks like this also isn't used?
|
|
||
| def _render_profile_data(self, value, keypath): | ||
| result = self.render_value(value) | ||
| if len(keypath) == 1 and keypath[-1] == 'port': |
There was a problem hiding this comment.
same comment from _convert_port: someday profile-specific rendering info should go on the adapter
There was a problem hiding this comment.
Adapters will have to provide their own credentials descriptions when they're plugins so I imagine I'll be forced to deal with this then.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement #960. Almost all fields in project/profile configs are now rendered.
Unrendered fields are 'on-run-end'/'on-run-start' in the root of a project config, and 'post-hook'/'pre-hook' under 'models' and 'seeds' in a project config.
Profile fields are rendered in a two-stage process (target, then targeted profile), to allow users to require nonexistent environment/cli variables on non-loaded targets without error.
The big config-side change, beyond the obvious rendering stuff, is having to pass the cli variables around to the various classmethod constructors so they can build a renderer.