-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Warn if timestamp updated_at field uses incompatible timestamp #10352
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10352 +/- ##
==========================================
- Coverage 88.94% 88.88% -0.07%
==========================================
Files 180 180
Lines 22787 22798 +11
==========================================
- Hits 20267 20263 -4
- Misses 2520 2535 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
|
core/dbt/events/core_types_pb2.py
Outdated
@@ -1,7 +1,7 @@ | |||
# -*- coding: utf-8 -*- | |||
# Generated by the protocol buffer compiler. DO NOT EDIT! | |||
# source: core_types.proto | |||
# Protobuf Python Version: 5.26.1 | |||
# Protobuf Python Version: 4.25.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally we'd have CI for this, but for now let's ensure we're using 5.26.1 if possible to generate the protos: #10456
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small note on core/dbt/events/core_types_pb2.py, otherwise looks good!
Added a tech debt ticket re: protoc versions; #10658 |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.8.latest 1.8.latest
# Navigate to the new working tree
cd .worktrees/backport-1.8.latest
# Create a new branch
git switch --create backport-10352-to-1.8.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c28cb92af51d7f2cb27618aeb43705ba951aa3ef
# Push it to GitHub
git push --set-upstream origin backport-10352-to-1.8.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.8.latest Then, create a pull request where the |
Co-authored-by: Michelle Ark <michelle.ark@dbtlabs.com>
resolves #10234
Problem
Snapshot tables use the 'get_snapshot_time' macro, which may be incompatible with the data type of the field specified as the 'updated_at' field, causing unexpected results.
Solution
Warn if the two sources of timestamp columns have different data types.
Checklist