Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #10422: add test for env_var casing on windows #10436

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Conversation

aranke
Copy link
Member

@aranke aranke commented Jul 12, 2024

Resolves #10422

Problem

Solution

  • I have a failing test
  • I tried a code fix, but didn't work, so need some guidance here @peterallenwebb

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development, and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Jul 12, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.82%. Comparing base (4c7d922) to head (521c485).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10436      +/-   ##
==========================================
+ Coverage   88.76%   88.82%   +0.05%     
==========================================
  Files         180      180              
  Lines       22564    22564              
==========================================
+ Hits        20029    20042      +13     
+ Misses       2535     2522      -13     
Flag Coverage Δ
integration 86.20% <ø> (+0.16%) ⬆️
unit 62.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.10% <ø> (ø)
Integration Tests 86.20% <ø> (+0.16%) ⬆️

@aranke aranke added the Skip Changelog Skips GHA to check for changelog file label Jul 15, 2024
@aranke aranke marked this pull request as ready for review July 15, 2024 20:55
@aranke aranke requested a review from a team as a code owner July 15, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Regression] Unable to access environment variables
2 participants