[Tidy First] add typing to dbt/cli/exceptions.py #10619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10619 +/- ##
==========================================
- Coverage 88.86% 88.85% -0.02%
==========================================
Files 180 180
Lines 22762 22765 +3
==========================================
- Hits 20228 20227 -1
- Misses 2534 2538 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
emmyoop
changed the title
QMalcolm
approved these changes
Aug 28, 2024
Comment on lines
+39
to
+46
| result: Union[ | ||
| bool, # debug | ||
| CatalogArtifact, # docs generate | ||
| List[str], # list/ls | ||
| Manifest, # parse | ||
| None, # clean, deps, init, source | ||
| RunExecutionResult, # build, compile, run, seed, snapshot, test, run-operation | ||
| ] = None, |
There was a problem hiding this comment.
Woof the fact that that is the type signature is rough 🙃 but I'm glad it's typed now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #
Problem
Missing typing for dbt/cli/exceptions.py
Solution
Add typing for dbt/cli/exceptions.py
Checklist