-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test after dbt-utils release #10625
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10625 +/- ##
==========================================
- Coverage 88.92% 88.86% -0.06%
==========================================
Files 180 180
Lines 22779 22779
==========================================
- Hits 20256 20243 -13
- Misses 2523 2536 +13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
(cherry picked from commit 98fddcf)
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-10625-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 98fddcf54ff985fc97e0aafccb357f3d93d3fdbd
# Push it to GitHub
git push --set-upstream origin backport-10625-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest Then, create a pull request where the |
# Conflicts: # tests/functional/dependencies/test_dependency_options.py
* rework test to ignore utils version (#10625) # Conflicts: # tests/functional/dependencies/test_dependency_options.py * fix spacing for 1.7
Problem
This test depended on a specific version of dbt-utils as a downstream dependency. dbt-utils had a new release and it broke our test assertion.
Solution
Skip over looking at the dbt-utils string.
Checklist