Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test after dbt-utils release #10625

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Fix test after dbt-utils release #10625

merged 1 commit into from
Aug 28, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Aug 28, 2024

Problem

This test depended on a specific version of dbt-utils as a downstream dependency. dbt-utils had a new release and it broke our test assertion.

Solution

Skip over looking at the dbt-utils string.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@emmyoop emmyoop requested a review from a team as a code owner August 28, 2024 20:12
@cla-bot cla-bot bot added the cla:yes label Aug 28, 2024
@emmyoop emmyoop added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Aug 28, 2024
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.86%. Comparing base (d652359) to head (ba3c35a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10625      +/-   ##
==========================================
- Coverage   88.92%   88.86%   -0.06%     
==========================================
  Files         180      180              
  Lines       22779    22779              
==========================================
- Hits        20256    20243      -13     
- Misses       2523     2536      +13     
Flag Coverage Δ
integration 86.11% <ø> (-0.13%) ⬇️
unit 62.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.35% <ø> (ø)
Integration Tests 86.11% <ø> (-0.13%) ⬇️

@emmyoop emmyoop merged commit 98fddcf into main Aug 28, 2024
68 of 69 checks passed
@emmyoop emmyoop deleted the er/fix-deps-test branch August 28, 2024 20:25
github-actions bot pushed a commit that referenced this pull request Aug 28, 2024
Copy link
Contributor

The backport to 1.7.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.7.latest 1.7.latest
# Navigate to the new working tree
cd .worktrees/backport-1.7.latest
# Create a new branch
git switch --create backport-10625-to-1.7.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 98fddcf54ff985fc97e0aafccb357f3d93d3fdbd
# Push it to GitHub
git push --set-upstream origin backport-10625-to-1.7.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.7.latest

Then, create a pull request where the base branch is 1.7.latest and the compare/head branch is backport-10625-to-1.7.latest.

emmyoop added a commit that referenced this pull request Aug 28, 2024
# Conflicts:
#	tests/functional/dependencies/test_dependency_options.py
emmyoop added a commit that referenced this pull request Aug 28, 2024
(cherry picked from commit 98fddcf)

Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
emmyoop added a commit that referenced this pull request Aug 29, 2024
* rework test to ignore utils version (#10625)

# Conflicts:
#	tests/functional/dependencies/test_dependency_options.py

* fix spacing for 1.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants