Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Calls to pre_model_hook() #10735

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Fix Calls to pre_model_hook() #10735

merged 1 commit into from
Sep 18, 2024

Conversation

peterallenwebb
Copy link
Contributor

This fixes two calls to pre_model_hook() which pass objects of the wrong type. The type used in other places this function is called is RuntimeConfigObject, but here a context dictionary was passed. This was causing errors for me in a very specific testing scenario, but looks like a more general problem.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@cla-bot cla-bot bot added the cla:yes label Sep 18, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.88%. Comparing base (ab500a9) to head (a3fdee7).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10735      +/-   ##
==========================================
- Coverage   88.90%   88.88%   -0.03%     
==========================================
  Files         180      180              
  Lines       22785    22856      +71     
==========================================
+ Hits        20257    20315      +58     
- Misses       2528     2541      +13     
Flag Coverage Δ
integration 86.08% <100.00%> (-0.05%) ⬇️
unit 62.42% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.42% <0.00%> (+0.05%) ⬆️
Integration Tests 86.08% <100.00%> (-0.05%) ⬇️

Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think you're correct.

@peterallenwebb peterallenwebb marked this pull request as ready for review September 18, 2024 18:08
@peterallenwebb peterallenwebb requested a review from a team as a code owner September 18, 2024 18:08
@peterallenwebb peterallenwebb merged commit 054c6fd into main Sep 18, 2024
66 of 69 checks passed
@peterallenwebb peterallenwebb deleted the paw/pre-model-hook-fix branch September 18, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants