Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated track_struct_event #10736

Merged
merged 1 commit into from
Sep 18, 2024
Merged

Conversation

mikealfare
Copy link
Contributor

Problem

snowplow_tracking is deprecating track_struct_event.

Solution

Per the suggestion in the deprecation warning, use StructuredEvent instead.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@mikealfare mikealfare self-assigned this Sep 18, 2024
@mikealfare mikealfare requested a review from a team as a code owner September 18, 2024 18:28
@cla-bot cla-bot bot added the cla:yes label Sep 18, 2024
@mikealfare mikealfare added Skip Changelog Skips GHA to check for changelog file and removed cla:yes labels Sep 18, 2024
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.95%. Comparing base (054c6fd) to head (ea4f0ef).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10736   +/-   ##
=======================================
  Coverage   88.95%   88.95%           
=======================================
  Files         181      181           
  Lines       22959    22960    +1     
=======================================
+ Hits        20424    20425    +1     
  Misses       2535     2535           
Flag Coverage Δ
integration 86.14% <66.66%> (+<0.01%) ⬆️
unit 62.37% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.37% <66.66%> (+<0.01%) ⬆️
Integration Tests 86.14% <66.66%> (+<0.01%) ⬆️

@mikealfare mikealfare merged commit 3e437a6 into main Sep 18, 2024
73 of 77 checks passed
@mikealfare mikealfare deleted the remove-track-struct-event branch September 18, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants