Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split out model vs microbatch execution #10737

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Split out model vs microbatch execution #10737

merged 3 commits into from
Sep 19, 2024

Commits on Sep 18, 2024

  1. Split model execution vs microbatch model execution in `ModelRunner.e… 

    …xecute`
    @QMalcolm
    QMalcolm committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    49851de View commit details
    Browse the repository at this point in the history

  2. Move the relationship caching back to after the post hook during mode… 

    …l execution

In commit 8fe5ea1 the adding of the relationship
to the adapter cache got moved to _before_ the post hook during model execution. This
was done because of some wonkiness of having the microbatch model and model execution
logic in the same place. Now that we've split the relevant logic, we can move the caching
back to it's original spot in the order of operations. We don't think this actually changes
anything, but we're moving it back juuuust in case because this is a very hot code path.
    @QMalcolm
    QMalcolm committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    89f1c67 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into qmalcolm--split-out-model-vs-microbatch-exec… 

    …ution
    @QMalcolm
    QMalcolm committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    5251a88 View commit details
    Browse the repository at this point in the history