Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement partial parsing for singular data tests configs in yaml files #11100

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Dec 5, 2024

Resolves #10801

Problem

Changes to singular data test configs in yaml files were not causing the singular data test nodes to be updated.

Solution

Add partial parsing code to handle data_tests sections in schema source files.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner December 5, 2024 19:56
@cla-bot cla-bot bot added the cla:yes label Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.16%. Comparing base (fdfe03d) to head (6938208).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11100      +/-   ##
==========================================
- Coverage   89.17%   89.16%   -0.01%     
==========================================
  Files         183      183              
  Lines       23783    23799      +16     
==========================================
+ Hits        21209    21221      +12     
- Misses       2574     2578       +4     
Flag Coverage Δ
integration 86.54% <94.11%> (-0.03%) ⬇️
unit 62.17% <5.88%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.17% <5.88%> (+<0.01%) ⬆️
Integration Tests 86.54% <94.11%> (-0.03%) ⬇️

@gshank gshank merged commit e32b8a9 into main Dec 5, 2024
62 of 63 checks passed
@gshank gshank deleted the data_tests_partial_parsing branch December 5, 2024 20:57
github-actions bot pushed a commit that referenced this pull request Dec 5, 2024
gshank added a commit that referenced this pull request Dec 5, 2024
…es (#11100) (#11101)

(cherry picked from commit e32b8a9)

Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Changes under data_tests: top-level key within properties.yml files not seen by partial parsing
2 participants