Warn if concurrent_batches config is set to True, but the available adapter doesn't support it
#11145
+608
−448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ithout adapter support Batches of microbatch models can be executed sequentially or concurrently. We try to figure out which to do intellegently. As part of that, we implemented an override, the model config `concurrent_batches`, to allow the user to bypass _some_ of our automatic detection. However a user _cannot_ for batches to run concurrently if theadapter doesn't support concurrent batches (declaring support is opt in). Thus if an adapter _doesn't_ suppor trunning batches concurrently, and a user tries to force concurrent execution via `concurrent_batches`, then we need to warn the user that that isn't happening.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11145 +/- ##
==========================================
- Coverage 88.91% 88.85% -0.06%
==========================================
Files 183 187 +4
Lines 23937 24001 +64
==========================================
+ Hits 21284 21327 +43
- Misses 2653 2674 +21
Flags with carried forward coverage won't be shown. Click here to find out more.
|
QMalcolm
force-pushed
the
qmalcolm--11122-warn-if-concurrent-batches-config-true-but-no-adapter-support
branch
from
27e7719 to
263fd3e
Compare
MichelleArk
reviewed
Dec 16, 2024
MichelleArk
approved these changes
Dec 16, 2024
QMalcolm
deleted the
qmalcolm--11122-warn-if-concurrent-batches-config-true-but-no-adapter-support
branch
github-actions bot
pushed a commit
that referenced
this pull request
Dec 16, 2024
…le adapter doesn't support it (#11145) * Begin producing warning when attempting to force concurrent batches without adapter support Batches of microbatch models can be executed sequentially or concurrently. We try to figure out which to do intelligently. As part of that, we implemented an override, the model config `concurrent_batches`, to allow the user to bypass _some_ of our automatic detection. However, a user _cannot_ for batches to run concurrently if the adapter doesn't support concurrent batches (declaring support is opt in). Thus, if an adapter _doesn't_ support running batches concurrently, and a user tries to force concurrent execution via `concurrent_batches`, then we need to warn the user that that isn't happening. * Add custom event type for warning about invalid `concurrent_batches` config * Fire `InvalidConcurrentBatchesConfig` warning via `warn_or_error` so it can be silenced (cherry picked from commit 6c61cb7)
QMalcolm
added a commit
that referenced
this pull request
Dec 16, 2024
…le adapter doesn't support it (#11145) (#11154) * Begin producing warning when attempting to force concurrent batches without adapter support Batches of microbatch models can be executed sequentially or concurrently. We try to figure out which to do intelligently. As part of that, we implemented an override, the model config `concurrent_batches`, to allow the user to bypass _some_ of our automatic detection. However, a user _cannot_ for batches to run concurrently if the adapter doesn't support concurrent batches (declaring support is opt in). Thus, if an adapter _doesn't_ support running batches concurrently, and a user tries to force concurrent execution via `concurrent_batches`, then we need to warn the user that that isn't happening. * Add custom event type for warning about invalid `concurrent_batches` config * Fire `InvalidConcurrentBatchesConfig` warning via `warn_or_error` so it can be silenced (cherry picked from commit 6c61cb7) Co-authored-by: Quigley Malcolm <QMalcolm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #11122
Problem
Batches of microbatch models can be executed sequentially or concurrently. We try to figure out which to do intelligently. As part of that, we implemented an override, the model config
concurrent_batches, to allow the user to bypass some of our automatic detection. However, a user cannot for batches to run concurrently if the adapter doesn't support concurrent batches (declaring support is opt in). Thus, if an adapter doesn't support running batches concurrently, and a user tries to force concurrent execution viaconcurrent_batches, then we need to warn the user that that isn't happening.Solution
After parse/load of manifest, check for whether the adapter supports concurrent batch execution and whether there are any microbatch models setting
concurrent_batches=True. If the adapter doesn't support concurrent batches and if there are any models withconcurrent_batches=True, fire a warning.Example:
Checklist