cache the macro manifest #1128
Merged
cache the macro manifest #1128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beckjake
approved these changes
Nov 19, 2018
dbt/loader.py
Outdated
|
|
||
| # make a manifest with just the macros to get the context |
There was a problem hiding this comment.
I think this belongs on line 36? The indentation is weird.
| @@ -59,7 +66,8 @@ def _load_seeds(self): | |||
| all_projects=self.all_projects, | |||
| root_dir=project.project_root, | |||
| relative_dirs=project.data_paths, | |||
| macros=self.macros | |||
| macros=self.macros, | |||
There was a problem hiding this comment.
A future cleanup PR could probably go back and remove the macros parameter here since they're part of the manifest, but I suspect it's actually a bit tricky to do so.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1098
I had played around with this a while back to inform how much of a speedup we'd get in parsing. This change really makes the parsing step fly! I took a pretty heavy-handed approach here, so I'm very open to feedback/suggestions on ways to do this better.
For our internal analytics project, this brings the "time to stdout" down from 11.1s to 6.8s. That's not a rigorous analysis, but I'm sure it will be welcomed by many.