fix analysis to only compile sql once like model nodes [#1152] #1164
+26
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewbanin
reviewed
Dec 3, 2018
| @@ -132,7 +132,7 @@ def compile_node(self, node, manifest, extra_context=None): | |||
|
|
|||
| injected_node, _ = prepend_ctes(compiled_node, manifest) | |||
|
|
|||
| should_wrap = {NodeType.Test, NodeType.Analysis, NodeType.Operation} | |||
| should_wrap = {NodeType.Test, NodeType.Operation} | |||
There was a problem hiding this comment.
i'm unsure why Analysis nodes were ever in here. We definitely do not wrap them. This whole function is... not good. Would be great to revisit at some point soon
drewbanin
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1152
Due to dbt's parsing structure, the existing analysis code compiles its contents twice, which is why
rawblocks aren't accepted. I've changed the compiler to treat Analysis nodes more like Models during compilation, instead of like seeds and tests. Based on what I found, custom tests probably don't respectrawblocks in their jinja and that's probably harder to fix.It's possible that I don't understand analysis nodes very well and so my fix is just totally wrong... there isn't much of an existing test suite around them.
This fix may also break existing code since it only renders the output once instead of twice, and people may have written analyses with this behavior in mind.