Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add node level timing info to run_results.json and to tracking #1242

Merged
merged 13 commits into from
Feb 1, 2019

Conversation

cmcarthur
Copy link
Member

Adds node level timing info to RunModelResult. this then propagates to run_results.json and to event tracking.

@drewbanin I think I need to update an IGLU schema for this to work properly, no?

@cmcarthur cmcarthur requested a review from drewbanin January 16, 2019 01:42
Copy link
Contributor

@drewbanin drewbanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cmcarthur this is really great! I love the context manager -- good idea. I think this is good to ship as-is, with a couple of other notes:

  • i like that we can extend this to include pre- and post- hooks at some point in the future. Unsure how we would do that at this very moment, but they'll fit right in when we get there.
  • this doesn't include on-run-start/end hooks, which i think is ok b/c they aren't represented in run_results.json at present. If that's an easy thing to do, I think we should do it! If it ends up requiring a ton of refactoring to support, we can punt on it until we generally revisit those hooks.
  • I think you're right that we'll need to update an iglu schema here. These things are versioned, and I think we might want to bump the run_model_spec to use 1-0-1. We'll need to make a PR in the relevant repo -- i can get that sorted

@cmcarthur cmcarthur merged commit 314b453 into dev/stephen-girard Feb 1, 2019
@cmcarthur cmcarthur deleted the add-node-level-timing-info branch February 1, 2019 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants