-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add node level timing info to run_results.json and to tracking #1242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t into add-node-level-timing-info
…t into add-node-level-timing-info
drewbanin
reviewed
Jan 19, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cmcarthur this is really great! I love the context manager -- good idea. I think this is good to ship as-is, with a couple of other notes:
- i like that we can extend this to include pre- and post- hooks at some point in the future. Unsure how we would do that at this very moment, but they'll fit right in when we get there.
- this doesn't include on-run-start/end hooks, which i think is ok b/c they aren't represented in
run_results.json
at present. If that's an easy thing to do, I think we should do it! If it ends up requiring a ton of refactoring to support, we can punt on it until we generally revisit those hooks. - I think you're right that we'll need to update an iglu schema here. These things are versioned, and I think we might want to bump the run_model_spec to use 1-0-1. We'll need to make a PR in the relevant repo -- i can get that sorted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds node level timing info to RunModelResult. this then propagates to run_results.json and to event tracking.
@drewbanin I think I need to update an IGLU schema for this to work properly, no?